]> git.hungrycats.org Git - linux/commit
staging: vchiq_arm: Use devm_kzalloc() for vchiq_arm_state allocation
authorUmang Jain <umang.jain@ideasonboard.com>
Wed, 16 Oct 2024 13:02:24 +0000 (18:32 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 22 Nov 2024 14:37:32 +0000 (15:37 +0100)
commit0708d3197f693164e5d4ecd9073cfca91a8c6856
tree0047c3d31bebf381b98dae5c1185f9109363588e
parentc26cff492697cde3c6687a4b62f078170b51e59a
staging: vchiq_arm: Use devm_kzalloc() for vchiq_arm_state allocation

[ Upstream commit 404b739e895522838f1abdc340c554654d671dde ]

The struct vchiq_arm_state 'platform_state' is currently allocated
dynamically using kzalloc(). Unfortunately, it is never freed and is
subjected to memory leaks in the error handling paths of the probe()
function.

To address the issue, use device resource management helper
devm_kzalloc(), to ensure cleanup after its allocation.

Fixes: 71bad7f08641 ("staging: add bcm2708 vchiq driver")
Cc: stable@vger.kernel.org
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20241016130225.61024-2-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c