]> git.hungrycats.org Git - linux/commit
ALSA: ac97: Fix possible NULL dereference in snd_ac97_mixer
authorSu Hui <suhui@nfschina.com>
Thu, 15 Jun 2023 02:17:32 +0000 (10:17 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 Jul 2023 17:39:42 +0000 (19:39 +0200)
commit09baf460dfba79ee6a0c72e68ccdbbba84d894df
tree172da80218a40adb7c25f841734951ca93978c70
parentd3ca34e186b7f6357a6b28bcd5fc5107c7992515
ALSA: ac97: Fix possible NULL dereference in snd_ac97_mixer

[ Upstream commit 79597c8bf64ca99eab385115743131d260339da5 ]

smatch error:
sound/pci/ac97/ac97_codec.c:2354 snd_ac97_mixer() error:
we previously assumed 'rac97' could be null (see line 2072)

remove redundant assignment, return error if rac97 is NULL.

Fixes: da3cec35dd3c ("ALSA: Kill snd_assert() in sound/pci/*")
Signed-off-by: Su Hui <suhui@nfschina.com>
Link: https://lore.kernel.org/r/20230615021732.1972194-1-suhui@nfschina.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/pci/ac97/ac97_codec.c