]> git.hungrycats.org Git - linux/commit
xfs: don't perform discard if the given range length is less than block size
authorJie Liu <jeff.liu@oracle.com>
Wed, 20 Nov 2013 08:08:53 +0000 (16:08 +0800)
committerJiri Slaby <jslaby@suse.cz>
Fri, 4 Jul 2014 08:06:58 +0000 (10:06 +0200)
commit0af3f13634228f13b0298551326a51b89d95a7e4
treed9fc17dee651029a145832863d97cbfcaaf32244
parentf7009499bc593c23ec4fe9525f4e545ad0c16691
xfs: don't perform discard if the given range length is less than block size

commit f9fd0135610084abef6867d984e9951c3099950d upstream.

For discard operation, we should return EINVAL if the given range length
is less than a block size, otherwise it will go through the file system
to discard data blocks as the end range might be evaluated to -1, e.g,
/xfs7: 9811378176 bytes were trimmed

This issue can be triggered via xfstests/generic/288.

Also, it seems to get the request queue pointer via bdev_get_queue()
instead of the hard code pointer dereference is not a bad thing.

Signed-off-by: Jie Liu <jeff.liu@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ben Myers <bpm@sgi.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
fs/xfs/xfs_discard.c