]> git.hungrycats.org Git - linux/commit
clk: imx: clk-imxrt1050: fix memory leak in imxrt1050_clocks_probe
authorKai Ma <kaima@hust.edu.cn>
Tue, 18 Apr 2023 11:34:51 +0000 (11:34 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 Jul 2023 17:39:41 +0000 (19:39 +0200)
commit0fbdfd2542252e4c02e8158a06b7c0c9cfd40f99
tree43e1b4b6b67d32c454fa3b64285a659a8a1229f9
parent5710bc67d7e977241ad4f8126191a03735612cca
clk: imx: clk-imxrt1050: fix memory leak in imxrt1050_clocks_probe

[ Upstream commit 1b280598ab3bd8a2dc8b96a12530d5b1ee7a8f4a ]

Use devm_of_iomap() instead of of_iomap() to automatically
handle the unused ioremap region. If any error occurs, regions allocated by
kzalloc() will leak, but using devm_kzalloc() instead will automatically
free the memory using devm_kfree().

Also, fix error handling of hws by adding unregister_hws label, which
unregisters remaining hws when iomap failed.

Fixes: 7154b046d8f3 ("clk: imx: Add initial support for i.MXRT1050 clock driver")
Signed-off-by: Kai Ma <kaima@hust.edu.cn>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Acked-by: Jesse Taube <Mr.Bossman075@gmail.com>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
Link: https://lore.kernel.org/r/20230418113451.151312-1-kaima@hust.edu.cn
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/clk/imx/clk-imxrt1050.c