]> git.hungrycats.org Git - linux/commit
[PATCH] USB: USB w9968cf compile error
authorAdrian Bunk <bunk@fs.tum.de>
Wed, 14 Jul 2004 08:08:37 +0000 (01:08 -0700)
committerGreg Kroah-Hartman <greg@kroah.com>
Wed, 14 Jul 2004 08:08:37 +0000 (01:08 -0700)
commit12744ffe7b51bcbe9ba114d3e4b6ccb2cd0ffac7
tree5a942417d0be41471efecdfb1e68ca12019ddf95
parent6e6fc3481821375887fe9c37d4231119a68f21c5
[PATCH] USB:  USB w9968cf compile error

On Tue, Jul 13, 2004 at 06:25:59PM -0700, Andrew Morton wrote:
>...
> All 252 patches:
>...
> bk-usb.patch
>...

This patch marks w9968cf_valid_depth as inline, although it's used
before it's defined.

gcc 3.4 therefore correctly fails with:

<--  snip  -->

...
  CC      drivers/usb/media/w9968cf.o
drivers/usb/media/w9968cf.c: In function `w9968cf_set_picture':
drivers/usb/media/w9968cf.c:487: sorry, unimplemented: inlining failed
in call to 'w9968cf_valid_depth': function body not available
drivers/usb/media/w9968cf.c:1722: sorry, unimplemented: called from here
make[3]: *** [drivers/usb/media/w9968cf.o] Error 1

<--  snip  -->

This patch moves w9968cf_valid_depth above it's first user (it also uses
two other functions to keep the ordering of functions a bit more
consistent).

Signed-off-by: Adrian Bunk <bunk@fs.tum.de>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
drivers/usb/media/w9968cf.c