]> git.hungrycats.org Git - linux/commit
Revert "i2c: core: Dispose OF IRQ mapping at client removal time"
authorJakub Kicinski <kubakici@wp.pl>
Wed, 11 Mar 2015 17:35:36 +0000 (18:35 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 26 Mar 2015 12:59:45 +0000 (13:59 +0100)
commit15f3667aa26cb5884cb6a1b9d1ba069be440ee66
treed7aa4b169dc969f8fd5045a87fa8f046720d3c8b
parent4b71a261c563ad9dc758ebe731b48a5d8317f73c
Revert "i2c: core: Dispose OF IRQ mapping at client removal time"

commit a49445727014216703a3c28ccee4cef36d41571e upstream.

This reverts commit e4df3a0b6228
("i2c: core: Dispose OF IRQ mapping at client removal time")

Calling irq_dispose_mapping() will destroy the mapping and disassociate
the IRQ from the IRQ chip to which it belongs. Keeping it is OK, because
existent mappings are reused properly.

Also, this commit breaks drivers using devm* for IRQ management on
OF-based systems because devm* cleanup happens in device code, after
bus's remove() method returns.

Signed-off-by: Jakub Kicinski <kubakici@wp.pl>
Reported-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
[wsa: updated the commit message with findings fromt the other bug report]
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Fixes: e4df3a0b6228
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/i2c/i2c-core.c