]> git.hungrycats.org Git - linux/commit
bpf: use type_may_be_null() helper for nullable-param check
authorShung-Hsi Yu <shung-hsi.yu@suse.com>
Thu, 5 Sep 2024 05:52:32 +0000 (13:52 +0800)
committerAlexei Starovoitov <ast@kernel.org>
Thu, 5 Sep 2024 20:29:06 +0000 (13:29 -0700)
commit1ae497c78f01855f3695b58481311ffdd429b028
tree58ae167e4e4a488a8be8f43541869bdf34458d0c
parentb9d32677ff1c2fe6c9c97c23341c6d69254d89cd
bpf: use type_may_be_null() helper for nullable-param check

Commit 980ca8ceeae6 ("bpf: check bpf_dummy_struct_ops program params for
test runs") does bitwise AND between reg_type and PTR_MAYBE_NULL, which
is correct, but due to type difference the compiler complains:

  net/bpf/bpf_dummy_struct_ops.c:118:31: warning: bitwise operation between different enumeration types ('const enum bpf_reg_type' and 'enum bpf_type_flag') [-Wenum-enum-conversion]
    118 |                 if (info && (info->reg_type & PTR_MAYBE_NULL))
        |                              ~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~

Workaround the warning by moving the type_may_be_null() helper from
verifier.c into bpf_verifier.h, and reuse it here to check whether param
is nullable.

Fixes: 980ca8ceeae6 ("bpf: check bpf_dummy_struct_ops program params for test runs")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202404241956.HEiRYwWq-lkp@intel.com/
Signed-off-by: Shung-Hsi Yu <shung-hsi.yu@suse.com>
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
Link: https://lore.kernel.org/r/20240905055233.70203-1-shung-hsi.yu@suse.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
include/linux/bpf_verifier.h
kernel/bpf/verifier.c
net/bpf/bpf_dummy_struct_ops.c