]> git.hungrycats.org Git - linux/commit
iio: gts: fix infinite loop for gain_to_scaletables()
authorZicheng Qu <quzicheng@huawei.com>
Thu, 31 Oct 2024 01:46:26 +0000 (01:46 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 9 Dec 2024 09:33:09 +0000 (10:33 +0100)
commit1bdff8a19cd6f7ef76eba3e6739d0f1702d49f06
treea5ed4301f40d4bbdb9ccaafa3fd92da4f5fa9646
parente5cac32721997cb8bcb208a29f4598b3faf46338
iio: gts: fix infinite loop for gain_to_scaletables()

commit 7452f8a0814bb73f739ee0dab60f099f3361b151 upstream.

In iio_gts_build_avail_time_table(), it is checked that gts->num_itime is
non-zero, but gts->num_itime is not checked in gain_to_scaletables(). The
variable time_idx is initialized as gts->num_itime - 1. This implies that
time_idx might initially be set to -1 (0 - 1 = -1). Consequently, using
while (time_idx--) could lead to an infinite loop.

Cc: stable@vger.kernel.org # v6.6+
Fixes: 38416c28e168 ("iio: light: Add gain-time-scale helpers")
Signed-off-by: Zicheng Qu <quzicheng@huawei.com>
Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
Link: https://patch.msgid.link/20241031014626.2313077-1-quzicheng@huawei.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iio/industrialio-gts-helper.c