]> git.hungrycats.org Git - linux/commit
[PATCH] fix oops in emu10k1_wavein_open() error recovery
authorAndrew Morton <akpm@osdl.org>
Sat, 6 Mar 2004 16:50:53 +0000 (08:50 -0800)
committerJaroslav Kysela <perex@suse.cz>
Sat, 6 Mar 2004 16:50:53 +0000 (08:50 -0800)
commit1cd4dae0fe148d0b213fea27c8db98eeb84878a1
tree7ec66ad6e038e5539f3cffaa18207dc9b609c794
parent50d89de71f02f932d7cf998a0ef1aa2823139d72
[PATCH] fix oops in emu10k1_wavein_open() error recovery

If a large pci_alloc_consistent() GFP_ATOMIC allocation fails this driver's
recovery code will call emu10k1_wavein_close() far earlier than it should: it
goes splat in emu10k1_timer_uninstall().

Fix it by simply removing that call: we haven't allocated any resources yet
anyway.

Note that one of the callers of emu10k1_wavein_open(), emu10k1_audio_read()
will sit there stupidly retrying the open.  But it has a sleep in there so
something might eventually give way.
sound/oss/emu10k1/cardwi.c