]> git.hungrycats.org Git - linux/commit
blk-mq: don't trust the cookie in blk_mq_poll()
authorJosef Bacik <josef@toxicpanda.com>
Wed, 28 Oct 2026 16:41:30 +0000 (10:41 -0600)
committerJens Axboe <axboe@kernel.dk>
Thu, 29 Oct 2026 13:15:47 +0000 (07:15 -0600)
commit24974185999fd80b676fbe2a6c7a97bbd38aaf3a
treebdedbadd04f99b505f835092d6f6715890c67931
parent67c43ceaa29e9b904216651697adf20445b219fc
blk-mq: don't trust the cookie in blk_mq_poll()

blk_mq_poll() indexes queue_hw_ctx[] with bio->bi_cookie unchecked. Zone
write plugging keeps the segment count of a plugged write in
__bi_nr_segments, which shares a union with the cookie, and clears
REQ_POLLED, but bio_poll() only looks at the cookie. A plugged polled
write with more segments than there are hardware queues reads past the
array. The bio is also SLAB_TYPESAFE_BY_RCU, so a cookie from a bio
reused for another device can meet the wrong array as well.

Ignore a cookie that is out of range or doesn't name a poll queue.

Fixes: 3e08773c3841 ("block: switch polling to be bio based")
Fixes: dd291d77cc90 ("block: Introduce zone write plugging")
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://patch.msgid.link/20261028164415.1262013-28-axboe@kernel.dk
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-mq.c