]> git.hungrycats.org Git - linux/commit
ALSA: usb-audio: qcom: Guard sideband endpoint removal
authorCássio Gabriel <cassiogabrielcontato@gmail.com>
Thu, 11 Jun 2026 13:57:22 +0000 (10:57 -0300)
committerTakashi Iwai <tiwai@suse.de>
Fri, 12 Jun 2026 09:01:47 +0000 (11:01 +0200)
commit2773023abb381e36ce02d364022d901f6f7a416d
tree5e2d14e167bdf3c7c6ad164aa47d955a47ce9eed
parentab8f7ffd63d5074c865935ad3720f0d995d2160f
ALSA: usb-audio: qcom: Guard sideband endpoint removal

qmi_stop_session() conditionally looks up the cached data and sync
endpoints, but removes each endpoint unconditionally.

The data endpoint is always present for an active offload stream, while
the sync endpoint is optional. When no sync endpoint exists, ep still
refers to the data endpoint and the code attempts to remove that endpoint
a second time. The current sideband implementation rejects the duplicate
removal, but the teardown path should not pass an unrelated endpoint for
an absent sync endpoint.

Only look up and remove an endpoint when its cached pipe exists, check the
lookup result, and clear the cached pipe after handling it. This matches
the normal stream-disable path.

Fixes: 326bbc348298 ("ALSA: usb-audio: qcom: Introduce QC USB SND offloading support")
Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>
Link: https://patch.msgid.link/20260611-alsa-usb-qcom-guard-sideband-endpoint-removal-v1-1-00e73787c156@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/qcom/qc_audio_offload.c