]> git.hungrycats.org Git - linux/commit
PCI: brcmstb: Use reset/rearm instead of deassert/assert
authorJim Quinlan <jim2101024@gmail.com>
Fri, 30 Apr 2021 15:21:56 +0000 (11:21 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 May 2021 08:29:44 +0000 (10:29 +0200)
commit281c236887705e25b82b1fd5803e71c12aec3bc4
treeaff17768986b96dbf69e4ccc5442ce3c4cbe4c49
parent4d3f043efd23467de3238362ae57e494d94d968b
PCI: brcmstb: Use reset/rearm instead of deassert/assert

[ Upstream commit bb610757fcd74558ad94fe19993fd4470208dd02 ]

The Broadcom STB PCIe RC uses a reset control "rescal" for certain chips.
The "rescal" implements a "pulse reset" so using assert/deassert is wrong
for this device.  Instead, we use reset/rearm.  We need to use rearm so
that we can reset it after a suspend/resume cycle; w/o using "rearm", the
"rescal" device will only ever fire once.

Of course for suspend/resume to work we also need to put the reset/rearm
calls in the suspend and resume routines.

Fixes: 740d6c3708a9 ("PCI: brcmstb: Add control of rescal reset")
Link: https://lore.kernel.org/r/20210430152156.21162-4-jim2101024@gmail.com
Signed-off-by: Jim Quinlan <jim2101024@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pci/controller/pcie-brcmstb.c