]> git.hungrycats.org Git - linux/commit
Fix vfat shortname character logic that had wrong signedness
authorLinus Torvalds <torvalds@home.osdl.org>
Fri, 18 Jul 2003 11:50:01 +0000 (04:50 -0700)
committerLinus Torvalds <torvalds@home.osdl.org>
Fri, 18 Jul 2003 11:50:01 +0000 (04:50 -0700)
commit2f88984e011b784f02b1644c9a82059998cea2c9
tree9c1acc7502127f8b1b06b034058bc92561438c1d
parent1d02c2c0dfe098493f1359da83f1f2ba551f40a6
Fix vfat shortname character logic that had wrong signedness
tests.

From Dennis Vshivkov:

  "whenever I was trying to create a file using only national
   characters for its name, it was always created with an
   uppercased shortname (provided that the name was not too
   long for 8.3, of course). Everything was fine with latin
   filenames, though."

The bug is that we check "buf[0]" as an unsigned character, but
"buf" is just "char *", which (depending on architecture and
compiler options) tends to be signed.
fs/vfat/namei.c