]> git.hungrycats.org Git - linux/commit
drivers/perf: hisi: hns3: Actually use devm_add_action_or_reset()
authorHao Chen <chenhao418@huawei.com>
Thu, 25 Apr 2024 12:46:27 +0000 (20:46 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 May 2024 07:49:17 +0000 (09:49 +0200)
commit2fcffaaf529d5fe3fdc6c0ee65a6f266b74de782
treec3165135a1f1ab4eb0b6bda52595a0d2b3da8a84
parentb5120d322763c15c978bc47beb3b6dff45624304
drivers/perf: hisi: hns3: Actually use devm_add_action_or_reset()

[ Upstream commit 582c1aeee0a9e73010cf1c4cef338709860deeb0 ]

pci_alloc_irq_vectors() allocates an irq vector. When devm_add_action()
fails, the irq vector is not freed, which leads to a memory leak.

Replace the devm_add_action with devm_add_action_or_reset to ensure
the irq vector can be destroyed when it fails.

Fixes: 66637ab137b4 ("drivers/perf: hisi: add driver for HNS3 PMU")
Signed-off-by: Hao Chen <chenhao418@huawei.com>
Signed-off-by: Junhao He <hejunhao3@huawei.com>
Reviewed-by: Jijie Shao <shaojijie@huawei.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/20240425124627.13764-4-hejunhao3@huawei.com
Signed-off-by: Will Deacon <will@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/perf/hisilicon/hns3_pmu.c