]> git.hungrycats.org Git - linux/commit
lib: string_helpers: silence snprintf() output truncation warning
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Fri, 1 Nov 2024 20:54:53 +0000 (21:54 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Dec 2024 12:54:25 +0000 (13:54 +0100)
commit33c5253b8f0abf1e2d2fbb9c4fa1713087f5d8c5
tree5480574a5a5fab7929dc09dcaea44004e4d1eef6
parentb286a9fc717e3ff92c3f7453355cb4490ac869df
lib: string_helpers: silence snprintf() output truncation warning

commit a508ef4b1dcc82227edc594ffae583874dd425d7 upstream.

The output of ".%03u" with the unsigned int in range [0, 4294966295] may
get truncated if the target buffer is not 12 bytes. This can't really
happen here as the 'remainder' variable cannot exceed 999 but the
compiler doesn't know it. To make it happy just increase the buffer to
where the warning goes away.

Fixes: 3c9f3681d0b4 ("[SCSI] lib: add generic helper to print sizes rounded to the correct SI range")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Cc: James E.J. Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Kees Cook <kees@kernel.org>
Cc: stable@vger.kernel.org
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Link: https://lore.kernel.org/r/20241101205453.9353-1-brgl@bgdev.pl
Signed-off-by: Kees Cook <kees@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
lib/string_helpers.c