]> git.hungrycats.org Git - linux/commit
tcp: fix tcp_cong_avoid_ai() credit accumulation bug with decreases in w
authorNeal Cardwell <ncardwell@google.com>
Tue, 10 Mar 2015 21:17:03 +0000 (17:17 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 26 Mar 2015 12:59:33 +0000 (13:59 +0100)
commit34081d1d2f13fb445194f42790636652525259ba
tree7ea386367f6a7ad8f9b28be34f5187709fa66c47
parentbe0e858e52ea730c06486a954b1984e07c9c39f1
tcp: fix tcp_cong_avoid_ai() credit accumulation bug with decreases in w

[ Upstream commit 9949afa42be0b76f5832db112ce51bb6b35b2abb ]

The recent change to tcp_cong_avoid_ai() to handle stretch ACKs
introduced a bug where snd_cwnd_cnt could accumulate a very large
value while w was large, and then if w was reduced snd_cwnd could be
incremented by a large delta, leading to a large burst and high packet
loss. This was tickled when CUBIC's bictcp_update() sets "ca->cnt =
100 * cwnd".

This bug crept in while preparing the upstream version of
814d488c6126.

Testing: This patch has been tested in datacenter netperf transfers
and live youtube.com and google.com servers.

Fixes: 814d488c6126 ("tcp: fix the timid additive increase on stretch ACKs")
Signed-off-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: Yuchung Cheng <ycheng@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ipv4/tcp_cong.c