]> git.hungrycats.org Git - linux/commit
net: wwan: t7xx: Fix off-by-one error in t7xx_dpmaif_rx_buf_alloc()
authorJinjie Ruan <ruanjinjie@huawei.com>
Fri, 1 Nov 2024 02:53:16 +0000 (10:53 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 14 Nov 2024 12:15:16 +0000 (13:15 +0100)
commit424c4acb3376f21d1c590304ab4695b5554746f4
tree9d8c696751eeb78e050b112facba233a7b1446b6
parentf6b2b2b981af8e7d7c62d34143acefa4e1edfe8b
net: wwan: t7xx: Fix off-by-one error in t7xx_dpmaif_rx_buf_alloc()

commit 3b557be89fc688dbd9ccf704a70f7600a094f13a upstream.

The error path in t7xx_dpmaif_rx_buf_alloc(), free and unmap the already
allocated and mapped skb in a loop, but the loop condition terminates when
the index reaches zero, which fails to free the first allocated skb at
index zero.

Check with i-- so that skb at index 0 is freed as well.

Cc: stable@vger.kernel.org
Fixes: d642b012df70 ("net: wwan: t7xx: Add data path interface")
Acked-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://patch.msgid.link/20241101025316.3234023-1-ruanjinjie@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wwan/t7xx/t7xx_hif_dpmaif_rx.c