]> git.hungrycats.org Git - linux/commit
drm/sched: Add locking to drm_sched_entity_modify_sched
authorTvrtko Ursulin <tvrtko.ursulin@igalia.com>
Fri, 13 Sep 2024 16:05:52 +0000 (17:05 +0100)
committerChristian König <christian.koenig@amd.com>
Thu, 26 Sep 2024 12:39:41 +0000 (14:39 +0200)
commit4286cc2c953983d44d248c9de1c81d3a9643345c
tree44119b4d34ebf633087b716397f82cdc501dbb9c
parentad604f0a4c040dcb8faf44dc72db25e457c28076
drm/sched: Add locking to drm_sched_entity_modify_sched

Without the locking amdgpu currently can race between
amdgpu_ctx_set_entity_priority() (via drm_sched_entity_modify_sched()) and
drm_sched_job_arm(), leading to the latter accesing potentially
inconsitent entity->sched_list and entity->num_sched_list pair.

v2:
 * Improve commit message. (Philipp)

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Fixes: b37aced31eb0 ("drm/scheduler: implement a function to modify sched list")
Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Luben Tuikov <ltuikov89@gmail.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Cc: Philipp Stanner <pstanner@redhat.com>
Cc: <stable@vger.kernel.org> # v5.7+
Reviewed-by: Christian König <christian.koenig@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240913160559.49054-2-tursulin@igalia.com
Signed-off-by: Christian König <christian.koenig@amd.com>
drivers/gpu/drm/scheduler/sched_entity.c