]> git.hungrycats.org Git - linux/commit
netlink: reset network header before passing to taps
authorDaniel Borkmann <dborkman@redhat.com>
Thu, 7 Aug 2014 20:22:47 +0000 (22:22 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 15 Oct 2014 10:05:26 +0000 (12:05 +0200)
commit47a0ff6c6d10ad4479a0d056bc02c69b0fc55729
treeabcbf22a9592d15cbf09fb546bfc8fc8d6db492d
parent13c24cc86702e823152cfaa8fd42adfc6bca182f
netlink: reset network header before passing to taps

[ Upstream commit 4e48ed883c72e78c5a910f8831ffe90c9b18f0ec ]

netlink doesn't set any network header offset thus when the skb is
being passed to tap devices via dev_queue_xmit_nit(), it emits klog
false positives due to it being unset like:

  ...
  [  124.990397] protocol 0000 is buggy, dev nlmon0
  [  124.990411] protocol 0000 is buggy, dev nlmon0
  ...

So just reset the network header before passing to the device; for
packet sockets that just means nothing will change - mac and net
offset hold the same value just as before.

Reported-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/netlink/af_netlink.c