]> git.hungrycats.org Git - linux/commit
bpftool: Fix undefined behavior caused by shifting into the sign bit
authorKuan-Wei Chiu <visitorckw@gmail.com>
Sun, 8 Sep 2024 14:00:09 +0000 (22:00 +0800)
committerAndrii Nakryiko <andrii@kernel.org>
Mon, 9 Sep 2024 22:57:09 +0000 (15:57 -0700)
commit4cdc0e4ce5e893bc92255f5f734d983012f2bc2e
tree95ccd61a746435eab3bcb4ce2c320cdb9c674b64
parent12707b9159e631af91c051fd102d469364b6ecc3
bpftool: Fix undefined behavior caused by shifting into the sign bit

Replace shifts of '1' with '1U' in bitwise operations within
__show_dev_tc_bpf() to prevent undefined behavior caused by shifting
into the sign bit of a signed integer. By using '1U', the operations
are explicitly performed on unsigned integers, avoiding potential
integer overflow or sign-related issues.

Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Acked-by: Quentin Monnet <qmo@kernel.org>
Link: https://lore.kernel.org/bpf/20240908140009.3149781-1-visitorckw@gmail.com
tools/bpf/bpftool/net.c