]> git.hungrycats.org Git - linux/commit
ceph: don't reference req after put
authorAlex Elder <elder@inktank.com>
Thu, 29 Nov 2012 14:37:03 +0000 (08:37 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 17 Jan 2013 16:46:48 +0000 (08:46 -0800)
commit4de98b629ee84b800da6f4a5f8b0f4cfba3a7e3c
tree25273812791302515bdcfd9c66f032c9ade398f1
parent46ed4fbffa67c423be6233a01e2fdf220ca8f5f0
ceph: don't reference req after put

(cherry picked from commit 7d5f24812bd182a2471cb69c1c2baf0648332e1f)

In __unregister_request(), there is a call to list_del_init()
referencing a request that was the subject of a call to
ceph_osdc_put_request() on the previous line.  This is not
safe, because the request structure could have been freed
by the time we reach the list_del_init().

Fix this by reversing the order of these lines.

Signed-off-by: Alex Elder <elder@inktank.com>
Reviewed-off-by: Sage Weil <sage@inktank.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ceph/osd_client.c