]> git.hungrycats.org Git - linux/commit
wifi: mt76: Drop unneeded mt76_register_debugfs_fops() return checks
authorIngyu Jang <ingyujang25@korea.ac.kr>
Tue, 19 May 2026 08:52:14 +0000 (17:52 +0900)
committerFelix Fietkau <nbd@nbd.name>
Tue, 9 Jun 2026 10:34:02 +0000 (10:34 +0000)
commit50a7f9f9d48eb50c0e95bef53358acb5af5cb3c6
tree1c61b533a17ab05e7c3db501eac95f0bc2c58bb2
parenta7d35545c2ce11849de4b4397abaf664d79acd28
wifi: mt76: Drop unneeded mt76_register_debugfs_fops() return checks

mt76_register_debugfs_fops() returns the dentry from
debugfs_create_dir(), which yields an error pointer on failure
(notably ERR_PTR(-ENODEV) when CONFIG_DEBUG_FS=n), never NULL. Per
commit ff9fb72bc077 ("debugfs: return error values, not NULL"),
callers do not need to check the return value.

Drop the dead !dir checks in mt7615/mt7915/mt7921/mt7925/mt7996
_init_debugfs(). Converting them to IS_ERR() instead would have
exposed a probe abort on CONFIG_DEBUG_FS=n, since each
*_init_debugfs() caller propagates the helper's return value.

This patch supersedes an earlier proposal that converted the checks
to IS_ERR().

Link: https://lore.kernel.org/all/20260514193243.2518979-1-ingyujang25@korea.ac.kr
Signed-off-by: Ingyu Jang <ingyujang25@korea.ac.kr>
Link: https://patch.msgid.link/20260519085214.164846-1-ingyujang25@korea.ac.kr
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7615/debugfs.c
drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c
drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c
drivers/net/wireless/mediatek/mt76/mt7925/debugfs.c
drivers/net/wireless/mediatek/mt76/mt7996/debugfs.c