]> git.hungrycats.org Git - linux/commit
spi: spi-xilinx: cleanup a check in xilinx_spi_txrx_bufs()
authordan.carpenter@oracle.com <dan.carpenter@oracle.com>
Sun, 9 Jun 2013 13:07:28 +0000 (16:07 +0300)
committerWilly Tarreau <w@1wt.eu>
Sat, 27 Aug 2016 09:40:41 +0000 (11:40 +0200)
commit51ace2618a8647a2031981b088a91635dc0d3e04
treef6e2a0d6a323bf9a8c45cde3088a0b978dd0e6dc
parent78308a4a651d1b6c4851f84d09ba0edb9803df97
spi: spi-xilinx: cleanup a check in xilinx_spi_txrx_bufs()

commit e33d085d11e54bc9fb07b2555cd104d8e7b3089b upstream.

'!' has higher precedence than comparisons so the original condition
is equivalent to "if (xspi->remaining_bytes == 0)".  This makes the
static checkers complain.

xspi->remaining_bytes is signed and from looking at the code
briefly, I think it might be able to go negative.  I suspect that
going negative may cause a bug, but I don't have the hardware and
can't test.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/spi/spi-xilinx.c