]> git.hungrycats.org Git - linux/commit
selftests/bpf: Fix a fd leak in error paths in open_netns
authorGeliang Tang <tanggeliang@kylinos.cn>
Tue, 23 Apr 2024 10:35:27 +0000 (18:35 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 May 2024 07:49:15 +0000 (09:49 +0200)
commit5383396623b7bac1426b87dffdde338953c0d3c6
tree0586022838aebd2706dca274da97af3d596a5e06
parent3463efd7d6e423a495f8e322553af702d89fb1c3
selftests/bpf: Fix a fd leak in error paths in open_netns

[ Upstream commit 151f7442436658ee84076681d8f52e987fe147ea ]

As Martin mentioned in review comment, there is an existing bug that
orig_netns_fd will be leaked in the later "goto fail;" case after
open("/proc/self/ns/net") in open_netns() in network_helpers.c. This
patch adds "close(token->orig_netns_fd);" before "free(token);" to
fix it.

Fixes: a30338840fa5 ("selftests/bpf: Move open_netns() and close_netns() into network_helpers.c")
Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
Link: https://lore.kernel.org/r/a104040b47c3c34c67f3f125cdfdde244a870d3c.1713868264.git.tanggeliang@kylinos.cn
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/testing/selftests/bpf/network_helpers.c