]> git.hungrycats.org Git - linux/commit
scsi: 3w-9xxx: Avoid disabling device if failing to enable it
authorLetu Ren <fantasquex@gmail.com>
Mon, 29 Aug 2022 11:01:15 +0000 (19:01 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Oct 2022 07:58:24 +0000 (09:58 +0200)
commit53b6d7e499983bebfd8b1816e2d16ea78a0098a3
tree5f2cd858e804847fcbe7772c5a706b2f057b264a
parente0b16bfbd3a4a8d09614046335f4482313e7c0c4
scsi: 3w-9xxx: Avoid disabling device if failing to enable it

[ Upstream commit 7eff437b5ee1309b34667844361c6bbb5c97df05 ]

The original code will "goto out_disable_device" and call
pci_disable_device() if pci_enable_device() fails. The kernel will generate
a warning message like "3w-9xxx 0000:00:05.0: disabling already-disabled
device".

We shouldn't disable a device that failed to be enabled. A simple return is
fine.

Link: https://lore.kernel.org/r/20220829110115.38789-1-fantasquex@gmail.com
Reported-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: Letu Ren <fantasquex@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/scsi/3w-9xxx.c