]> git.hungrycats.org Git - linux/commit
usb: host: fix incorrect updating of offset
authorColin Ian King <colin.king@canonical.com>
Tue, 7 Nov 2017 16:45:04 +0000 (16:45 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 9 Dec 2017 17:29:48 +0000 (18:29 +0100)
commit5b45ab61a85666735663dbdbff8f214f25beb9e2
treea35df2d4604f76329068214d99d49f645ae171c0
parentc051e2d3d8e86d04a21072a962a6457116d13393
usb: host: fix incorrect updating of offset

commit 1d5a31582ef046d3b233f0da1a68ae26519b2f0a upstream.

The variable temp is incorrectly being updated, instead it should
be offset otherwise the loop just reads the same capability value
and loops forever.  Thanks to Alan Stern for pointing out the
correct fix to my original fix.  Fix also cleans up clang warning:

drivers/usb/host/ehci-dbg.c:840:4: warning: Value stored to 'temp'
is never read

Fixes: d49d43174400 ("USB: misc ehci updates")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/ehci-dbg.c