]> git.hungrycats.org Git - linux/commit
tcp: avoid infinite loop in tcp_splice_read()
authorEric Dumazet <edumazet@google.com>
Fri, 3 Feb 2017 22:59:38 +0000 (14:59 -0800)
committerBen Hutchings <ben@decadent.org.uk>
Sun, 26 Feb 2017 20:01:50 +0000 (20:01 +0000)
commit5b746247d798a6061d213bf3f64c6e434bb4f23d
tree5cdd8db7d90d901c1b0f3ac4d20f29b839a1c0e3
parentc21341fd2c2e0e840864062707825d6d0d5e13b2
tcp: avoid infinite loop in tcp_splice_read()

commit ccf7abb93af09ad0868ae9033d1ca8108bdaec82 upstream.

Splicing from TCP socket is vulnerable when a packet with URG flag is
received and stored into receive queue.

__tcp_splice_read() returns 0, and sk_wait_data() immediately
returns since there is the problematic skb in queue.

This is a nice way to burn cpu (aka infinite loop) and trigger
soft lockups.

Again, this gem was found by syzkaller tool.

Fixes: 9c55e01c0cc8 ("[TCP]: Splice receive support.")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Cc: Willy Tarreau <w@1wt.eu>
Signed-off-by: David S. Miller <davem@davemloft.net>
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/ipv4/tcp.c