]> git.hungrycats.org Git - linux/commit
smb: Initialize cfid->tcon before performing network ops
authorPaul Aurich <paul@darkrain42.org>
Wed, 27 Nov 2024 00:50:31 +0000 (18:50 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 9 Dec 2024 09:32:59 +0000 (10:32 +0100)
commit625e2357c8fcfae6e66dcc667dc656fe390bab15
tree4a1cce6abf795fdf7b62e3f59fe1a0724644ab01
parent0dd7a8b948fd8721ba5a7252888c22bc6cad3063
smb: Initialize cfid->tcon before performing network ops

[ Upstream commit c353ee4fb119a2582d0e011f66a76a38f5cf984d ]

Avoid leaking a tcon ref when a lease break races with opening the
cached directory. Processing the leak break might take a reference to
the tcon in cached_dir_lease_break() and then fail to release the ref in
cached_dir_offload_close, since cfid->tcon is still NULL.

Fixes: ebe98f1447bb ("cifs: enable caching of directories for which a lease is held")
Signed-off-by: Paul Aurich <paul@darkrain42.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/smb/client/cached_dir.c