]> git.hungrycats.org Git - linux/commit
powerpc/powernv/sriov: perform null check on iov before dereferencing iov
authorColin Ian King <colin.i.king@gmail.com>
Thu, 8 Jun 2023 09:58:49 +0000 (10:58 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 Jul 2023 17:39:48 +0000 (19:39 +0200)
commit6314465b88072a6b6f3b3c12a7898abe09095f95
treedbadd27dee2d56a1a5531506df4e0083314b1667
parentaccac779321739c04a33feef1d240cbee901011f
powerpc/powernv/sriov: perform null check on iov before dereferencing iov

[ Upstream commit f4f913c980bc6abe0ccfe88fe3909c125afe4a2d ]

Currently pointer iov is being dereferenced before the null check of iov
which can lead to null pointer dereference errors. Fix this by moving the
iov null check before the dereferencing.

Detected using cppcheck static analysis:
linux/arch/powerpc/platforms/powernv/pci-sriov.c:597:12: warning: Either
the condition '!iov' is redundant or there is possible null pointer
dereference: iov. [nullPointerRedundantCheck]
 num_vfs = iov->num_vfs;
           ^

Fixes: 052da31d45fc ("powerpc/powernv/sriov: De-indent setup and teardown")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20230608095849.1147969-1-colin.i.king@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/powerpc/platforms/powernv/pci-sriov.c