]> git.hungrycats.org Git - linux/commit
[PATCH] USB: fix dvb-ttusb-budget driver due to set_configuration locking cleanups
authorDavid Brownell <david-b@pacbell.net>
Tue, 30 Mar 2004 09:18:44 +0000 (01:18 -0800)
committerGreg Kroah-Hartman <greg@kroah.com>
Tue, 30 Mar 2004 09:18:44 +0000 (01:18 -0800)
commit6334e7866549676f4aa88872993a46114b9031bd
treedf730ab72608aa17b4cdbb8589ac5584bd24a086
parentd4f1dca6fb02a3d33aa4beb74e80a3f14fa3c30f
[PATCH] USB: fix dvb-ttusb-budget driver due to set_configuration locking cleanups

> Oops, you forgot to grep:
>
> CC [M]  drivers/media/dvb/ttusb-dec/ttusb_dec.o
> drivers/media/dvb/ttusb-budget/dvb-ttusb-budget.c: In function `ttusb_setup_interfaces':
> drivers/media/dvb/ttusb-budget/dvb-ttusb-budget.c:1011: warning: implicit declaration of function `usb_set_configuration'

Well, when I did the grep that bug wasn't there; it
was just integrated on Feb 26!

> Care to send a patch to fix it up before Andrew gets grumpy with me for
> breaking his build?  :)

The first part makes it use usb_reset_configuration() like
it did before ... I'm surprised this driver hasn't been
generating "it deadlocks during probe" reports.

The second part prints a diagnostic if the configuration
wasn't set right; the fix would use hotplug and sysfs.
drivers/media/dvb/ttusb-budget/dvb-ttusb-budget.c