]> git.hungrycats.org Git - linux/commit
USB: serial: ti_usb_3410_5052: fix array underflow in completion handler
authorJohan Hovold <johan@kernel.org>
Tue, 21 Aug 2018 09:59:53 +0000 (11:59 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Sep 2018 06:33:59 +0000 (08:33 +0200)
commit66688f6191c9299ccb8ccf3e1dc99cc59b194587
tree9984f9cff08b1a998c79865bd2af3a661ba30ad0
parentcf9bbea6229e8aca683c3a59d43fc926dc19163a
USB: serial: ti_usb_3410_5052: fix array underflow in completion handler

commit 5dfdd24eb3d39d815bc952ae98128e967c9bba49 upstream.

Similarly to a recently reported bug in io_ti, a malicious USB device
could set port_number to a negative value and we would underflow the
port array in the interrupt completion handler.

As these devices only have one or two ports, fix this by making sure we
only consider the seventh bit when determining the port number (and
ignore bits 0xb0 which are typically set to 0x30).

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/serial/ti_usb_3410_5052.h