]> git.hungrycats.org Git - linux/commit
drm: fix mutex leak in drm_dp_get_mst_branch_device
authorAdam Richter <adamrichter4@gmail.com>
Fri, 16 Oct 2015 10:33:02 +0000 (03:33 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 9 Nov 2015 22:37:31 +0000 (14:37 -0800)
commit6766f494c5df4e3e2662635babf97734ef180eb3
tree18657be95e18fa4221288cc93b4140afa81981a1
parentc9270c4850214bbd0798c171fafef7520cafdfd5
drm: fix mutex leak in drm_dp_get_mst_branch_device

commit 30730c7f5943b3beace1e29f7f1476e05de3da14 upstream.

In Linux 4.3-rc5, there is an error case in drm_dp_get_branch_device
that returns without releasing mgr->lock, resulting a spew of kernel
messages about a kernel work function possibly having leaked a mutex
and presumably more serious adverse consequences later.  This patch
changes the error to "goto out" to unlock the mutex before returning.

[airlied: grabbed from drm-next as it fixes something we've seen]

Signed-off-by: Adam J. Richter <adam_richter2004@yahoo.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/drm_dp_mst_topology.c