]> git.hungrycats.org Git - linux/commit
clockevents: Prevent oneshot mode when broadcast device is periodic
authorThomas Gleixner <tglx@linutronix.de>
Fri, 25 Feb 2011 21:34:23 +0000 (22:34 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 7 Mar 2011 23:05:20 +0000 (15:05 -0800)
commit69d2dd738ce984fd0b7ab25c8f179ba07c56d2e0
tree9ff8fb281a0c92dbcadbb2b276040a976198d7c4
parentca3edc920f5fd7d8ac040caaf109f925c24620a0
clockevents: Prevent oneshot mode when broadcast device is periodic

commit 3a142a0672b48a853f00af61f184c7341ac9c99d upstream.

When the per cpu timer is marked CLOCK_EVT_FEAT_C3STOP, then we only
can switch into oneshot mode, when the backup broadcast device
supports oneshot mode as well. Otherwise we would try to switch the
broadcast device into an unsupported mode unconditionally. This went
unnoticed so far as the current available broadcast devices support
oneshot mode. Seth unearthed this problem while debugging and working
around an hpet related BIOS wreckage.

Add the necessary check to tick_is_oneshot_available().

Reported-and-tested-by: Seth Forshee <seth.forshee@canonical.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
LKML-Reference: <alpine.LFD.2.00.1102252231200.2701@localhost6.localdomain6>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
kernel/time/tick-broadcast.c
kernel/time/tick-common.c
kernel/time/tick-internal.h