]> git.hungrycats.org Git - linux/commit
staging: rtl8723bs: fix potential memory leak in rtw_init_drv_sw()
authorXiaoke Wang <xkernel.wang@foxmail.com>
Fri, 9 Sep 2022 10:39:35 +0000 (18:39 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Oct 2022 07:58:27 +0000 (09:58 +0200)
commit6b2052b365f8035ab7f09ac24b5b499002b298cb
tree191233b36e2776e2774db6a43fbc6d87125947fa
parent65bb21134ffc21dd0275cae21fef180ef7d6125e
staging: rtl8723bs: fix potential memory leak in rtw_init_drv_sw()

[ Upstream commit 5a5aa9cce621e2c0e25a1e5d72d6be1749167cc0 ]

In rtw_init_drv_sw(), there are various init functions are called to
populate the padapter structure and some checks for their return value.
However, except for the first one error path, the other five error paths
do not properly release the previous allocated resources, which leads to
various memory leaks.

This patch fixes them and keeps the success and error separate.
Note that these changes keep the form of `rtw_init_drv_sw()` in
"drivers/staging/r8188eu/os_dep/os_intfs.c". As there is no proper device
to test with, no runtime testing was performed.

Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
Link: https://lore.kernel.org/r/tencent_C3B899D2FC3F1BC827F3552E0B0734056006@qq.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/staging/rtl8723bs/os_dep/os_intfs.c