]> git.hungrycats.org Git - linux/commit
soc: fsl: cpm1: qmc: Set the ret error code on platform_get_irq() failure
authorHerve Codina <herve.codina@bootlin.com>
Tue, 5 Nov 2024 14:56:23 +0000 (15:56 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Dec 2024 13:02:57 +0000 (14:02 +0100)
commit7168d14c2d2c98288522a1582a0002fdfd07234a
tree35e2468c58c0671c061b18bc86456a139803f33e
parent343e3e903ce950a639b9b0dac8827d621cb0475c
soc: fsl: cpm1: qmc: Set the ret error code on platform_get_irq() failure

commit cb3daa51db819a172e9524e96e2ed96b4237e51a upstream.

A kernel test robot detected a missing error code:
   qmc.c:1942 qmc_probe() warn: missing error code 'ret'

Indeed, the error returned by platform_get_irq() is checked and the
operation is aborted in case of failure but the ret error code is
not set in that case.

Set the ret error code.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202411051350.KNy6ZIWA-lkp@intel.com/
Fixes: 3178d58e0b97 ("soc: fsl: cpm1: Add support for QMC")
Cc: stable@vger.kernel.org
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Link: https://lore.kernel.org/r/20241105145623.401528-1-herve.codina@bootlin.com
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/soc/fsl/qe/qmc.c