]> git.hungrycats.org Git - linux/commit
rxrpc: fix io_thread race in rxrpc_wake_up_io_thread()
authorXuanqiang Luo <luoxuanqiang@kylinos.cn>
Wed, 8 Jul 2026 09:35:34 +0000 (17:35 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 21 Jul 2026 09:52:29 +0000 (11:52 +0200)
commit745fb794c3e933c023af9dbb5876a5e16ad2dc71
treef931f2019c07bc327d51ae26242e6a7778421cbc
parent96e37e2f618e931aa97af95e707dcdfb1ec41264
rxrpc: fix io_thread race in rxrpc_wake_up_io_thread()

rxrpc_wake_up_io_thread() checks local->io_thread before waking it, but
then reloads the pointer for wake_up_process().

local->io_thread is cleared with WRITE_ONCE() when the I/O thread exits, so
the second load can see NULL even if the first load did not.

Take a READ_ONCE() snapshot and use it for both the NULL check and the
wake_up_process() call, as rxrpc_encap_rcv() already does.

Fixes: 5800b1cf3fd8 ("rxrpc: Allow CHALLENGEs to the passed to the app for a RESPONSE")
Signed-off-by: Xuanqiang Luo <luoxuanqiang@kylinos.cn>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20260708093534.53486-1-xuanqiang.luo@linux.dev
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/rxrpc/ar-internal.h