]> git.hungrycats.org Git - linux/commit
rtlwifi: rtl8192cu: Fix duplicate if test
authorLarry Finger <Larry.Finger@lwfinger.net>
Tue, 18 Jun 2013 18:25:05 +0000 (13:25 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 22 Jul 2013 01:19:00 +0000 (18:19 -0700)
commit76a4f3b621d867ea7e27a1b985d7e1430355fac6
treeec2d57f2272c1354b6c1d2285048874395329d0c
parent5ce19a4e920ea5ab5246df8e6d5e698a94f9afa2
rtlwifi: rtl8192cu: Fix duplicate if test

commit 10d0b9030a3f86e1e26c710c7580524d7787d688 upstream.

A typo causes routine rtl92cu_phy_rf6052_set_cck_txpower() to test the
same condition twice. The problem was found using cppcheck-1.49, and the
proper fix was verified against the pre-mac80211 version of the code.

This patch was originally included as commit 1288aa4, but was accidentally
reverted in a later patch.

Reported-by: David Binderman <dcb314@hotmail.com> [original report]
Reported-by: Andrea Morello <andrea.merello@gmail.com> [report of accidental reversion]
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wireless/rtlwifi/rtl8192cu/rf.c