]> git.hungrycats.org Git - linux/commit
ACPI: EC: Avoid returning AE_OK on errors in address space handler
authorArmin Wolf <W_Armin@gmx.de>
Wed, 22 May 2024 21:36:49 +0000 (23:36 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Jul 2024 07:53:20 +0000 (09:53 +0200)
commit78780594b81d1afc0292a2d1cdcd36c7e79b1dcd
tree8b984c7e52dcd4080590380c40c51fcec9073a27
parent2d1d84ecc02a45a7cb8761e597950caf8b6c3d60
ACPI: EC: Avoid returning AE_OK on errors in address space handler

[ Upstream commit c4bd7f1d78340e63de4d073fd3dbe5391e2996e5 ]

If an error code other than EINVAL, ENODEV or ETIME is returned
by acpi_ec_read() / acpi_ec_write(), then AE_OK is incorrectly
returned by acpi_ec_space_handler().

Fix this by only returning AE_OK on success, and return AE_ERROR
otherwise.

Signed-off-by: Armin Wolf <W_Armin@gmx.de>
[ rjw: Subject and changelog edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/acpi/ec.c