]> git.hungrycats.org Git - linux/commit
batman-adv: properly check pskb_may_pull return value
authorAntonio Quartulli <antonio@meshcoding.com>
Wed, 29 Jan 2014 23:12:24 +0000 (00:12 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 7 Mar 2014 06:06:16 +0000 (22:06 -0800)
commit7a2f20aab51e33ee083d5f285275dc8b54f74be4
treea26fc5c8d86a8099dc12232c95a6a4bf14218558
parentb6cd79c3db913215ab2f162e58155527895d7f68
batman-adv: properly check pskb_may_pull return value

[ Upstream commit f1791425cf0bcda43ab9a9a37df1ad3ccb1f6654 ]

pskb_may_pull() returns 1 on success and 0 in case of failure,
therefore checking for the return value being negative does
not make sense at all.

This way if the function fails we will probably read beyond the current
skb data buffer. Fix this by doing the proper check.

Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/batman-adv/routing.c