]> git.hungrycats.org Git - linux/commit
drm/vmwgfx: Fix 32-bit VMW_PORT_HB_[IN|OUT] macros
authorThomas Hellstrom <thellstrom@vmware.com>
Wed, 23 May 2018 14:11:24 +0000 (16:11 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 May 2018 06:17:16 +0000 (08:17 +0200)
commit7a42da880f700c3f80f917ee4d355bc4b5b6cb15
treec0bb108324c2e8c9a67968f040ea20f0d0850c8f
parent76edcd337360791a3baa9552bcecf2721253cb34
drm/vmwgfx: Fix 32-bit VMW_PORT_HB_[IN|OUT] macros

commit 938ae7259c908ad031da35d551da297640bb640c upstream.

Depending on whether the kernel is compiled with frame-pointer or not,
the temporary memory location used for the bp parameter in these macros
is referenced relative to the stack pointer or the frame pointer.
Hence we can never reference that parameter when we've modified either
the stack pointer or the frame pointer, because then the compiler would
generate an incorrect stack reference.

Fix this by pushing the temporary memory parameter on a known location on
the stack before modifying the stack- and frame pointers.

Cc: <stable@vger.kernel.org>
Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
Reviewed-by: Brian Paul <brianp@vmware.com>
Reviewed-by: Sinclair Yeh <syeh@vmware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/vmwgfx/vmwgfx_msg.h