]> git.hungrycats.org Git - linux/commit
tomoyo: fix UAF write bug in tomoyo_write_control()
authorTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Fri, 1 Mar 2024 13:04:06 +0000 (22:04 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 6 Mar 2024 14:38:48 +0000 (14:38 +0000)
commit7d930a4da17958f869ef679ee0e4a8729337affc
treea62b589a3d1691afb220ae3d5a109cae15c6777e
parent5941a90c55d3bfba732b32208d58d997600b44ef
tomoyo: fix UAF write bug in tomoyo_write_control()

commit 2f03fc340cac9ea1dc63cbf8c93dd2eb0f227815 upstream.

Since tomoyo_write_control() updates head->write_buf when write()
of long lines is requested, we need to fetch head->write_buf after
head->io_sem is held.  Otherwise, concurrent write() requests can
cause use-after-free-write and double-free problems.

Reported-by: Sam Sun <samsun1006219@gmail.com>
Closes: https://lkml.kernel.org/r/CAEkJfYNDspuGxYx5kym8Lvp--D36CMDUErg4rxfWFJuPbbji8g@mail.gmail.com
Fixes: bd03a3e4c9a9 ("TOMOYO: Add policy namespace support.")
Cc: <stable@vger.kernel.org> # Linux 3.1+
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
security/tomoyo/common.c