]> git.hungrycats.org Git - linux/commit
ipmi:ssif: Fix a memory leak when scanning for an adapter
authorCorey Minyard <minyard@acm.org>
Mon, 19 Jun 2023 16:43:33 +0000 (11:43 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 13 Sep 2023 07:48:19 +0000 (09:48 +0200)
commit7db16d2e791bf2ec3e0249f56b7ec81c35bba6e6
tree3c5bca10629c1db8c8b05c44fa12f1479a579b23
parent2959a03cb7e71bdd446bebfbb6d896a6324d3d96
ipmi:ssif: Fix a memory leak when scanning for an adapter

[ Upstream commit b8d72e32e1453d37ee5c8a219f24e7eeadc471ef ]

The adapter scan ssif_info_find() sets info->adapter_name if the adapter
info came from SMBIOS, as it's not set in that case.  However, this
function can be called more than once, and it will leak the adapter name
if it had already been set.  So check for NULL before setting it.

Fixes: c4436c9149c5 ("ipmi_ssif: avoid registering duplicate ssif interface")
Signed-off-by: Corey Minyard <minyard@acm.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/char/ipmi/ipmi_ssif.c