]> git.hungrycats.org Git - linux/commit
bridge: Check if vlan filtering is enabled only once.
authorVlad Yasevich <vyasevich@gmail.com>
Fri, 12 Sep 2014 20:26:16 +0000 (16:26 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 15 Oct 2014 10:05:28 +0000 (12:05 +0200)
commit84351f1abd0a4e53a739c8714a7584b52a0386f5
tree474a70f2a4f13ead77602fe21c27b373cb8c9773
parentbcbfd0c0a36147834e337cb76357cadedc822f90
bridge: Check if vlan filtering is enabled only once.

[ Upstream commit 20adfa1a81af00bf2027644507ad4fa9cd2849cf ]

The bridge code checks if vlan filtering is enabled on both
ingress and egress.   When the state flip happens, it
is possible for the bridge to currently be forwarding packets
and forwarding behavior becomes non-deterministic.  Bridge
may drop packets on some interfaces, but not others.

This patch solves this by caching the filtered state of the
packet into skb_cb on ingress.  The skb_cb is guaranteed to
not be over-written between the time packet entres bridge
forwarding path and the time it leaves it.  On egress, we
can then check the cached state to see if we need to
apply filtering information.

Signed-off-by: Vladislav Yasevich <vyasevic@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/bridge/br_private.h
net/bridge/br_vlan.c