]> git.hungrycats.org Git - linux/commit
enic: do not overwrite error code
authorGovindarajulu Varadarajan <gvaradar@cisco.com>
Mon, 18 Jun 2018 17:01:05 +0000 (10:01 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 10 Nov 2018 15:42:55 +0000 (07:42 -0800)
commit8576adcc101dc5d3308c2dbd81dbc651ce70b0b4
treefe60e39ff377cf2a8e69d2ae5b34e18b93e0c7ae
parent8e697f95532ddb0e6ae93ed01c276030655d36b4
enic: do not overwrite error code

[ Upstream commit 56f772279a762984f6e9ebbf24a7c829faba5712 ]

In failure path, we overwrite err to what vnic_rq_disable() returns. In
case it returns 0, enic_open() returns success in case of error.

Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Fixes: e8588e268509 ("enic: enable rq before updating rq descriptors")
Signed-off-by: Govindarajulu Varadarajan <gvaradar@cisco.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/cisco/enic/enic_main.c