]> git.hungrycats.org Git - linux/commit
firmware: google: Skip failing entries instead of aborting populate
authorTitouan Ameline de Cadeville <titouan.ameline@gmail.com>
Fri, 1 May 2026 09:43:22 +0000 (11:43 +0200)
committerTzung-Bi Shih <tzungbi@kernel.org>
Sun, 3 May 2026 01:40:06 +0000 (09:40 +0800)
commit86e3bbc716332600e9e087f8a4889f4d9714a99c
tree645e627cd68cb9c9941d888aaa2ec1b8c32f76af
parent7b1a1af4556a4f95ef273e91435fe804cbfcd223
firmware: google: Skip failing entries instead of aborting populate

coreboot_table_populate() registers devices one by one. If
device_register() fails for one entry, the current code returns
immediately, leaving previously registered devices orphaned on the
coreboot bus with no cleanup path.

Since coreboot table entries are independent of each other, a failure
on one entry should not prevent the others from being registered.
This mirrors the strategy used by of_platform_populate(), which skips
individual failures rather than aborting.

Move ptr_entry increment before device_register(), log a warning on
failure, and continue the loop rather than aborting.

Signed-off-by: Titouan Ameline de Cadeville <titouan.ameline@gmail.com>
Reviewed-by: Julius Werner <jwerner@chromium.org>
Acked-by: Brian Norris <briannorris@chromium.org>
Link: https://lore.kernel.org/r/20260501094322.123160-1-titouan.ameline@gmail.com
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
drivers/firmware/google/coreboot_table.c