]> git.hungrycats.org Git - linux/commit
i2c-algo-bit: Fix spurious SCL timeouts under heavy load
authorVille Syrjala <syrjala@sci.fi>
Thu, 15 Mar 2012 17:11:05 +0000 (18:11 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 19 Mar 2012 16:02:35 +0000 (09:02 -0700)
commit883eb9633dcc5d3cc2389110508805d1d80c9d09
tree5d02e989cee61e17cbe8376062656ee71afcb3bc
parentaefb9269d572052d401c830eab28204d82731759
i2c-algo-bit: Fix spurious SCL timeouts under heavy load

commit 8ee161ce5e0cfc689eb677f227a6248191165fac upstream.

When the system is under heavy load, there can be a significant delay
between the getscl() and time_after() calls inside sclhi(). That delay
may cause the time_after() check to trigger after SCL has gone high,
causing sclhi() to return -ETIMEDOUT.

To fix the problem, double check that SCL is still low after the
timeout has been reached, before deciding to return -ETIMEDOUT.

Signed-off-by: Ville Syrjala <syrjala@sci.fi>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/i2c/algos/i2c-algo-bit.c