]> git.hungrycats.org Git - linux/commit
dmaengine: dmatest: warn user when dma test times out
authorAdam Wallis <awallis@codeaurora.org>
Thu, 2 Nov 2017 12:53:30 +0000 (08:53 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 21 Nov 2017 08:21:18 +0000 (09:21 +0100)
commit8d9142ff444e789d8ac34db1db5214a043484f86
tree8b0b5bb35e965a27f2dbdd7cb1391a4837879d5e
parentec4f8a71c0fc3c2ad0c40e01abcaf12631dd9ce2
dmaengine: dmatest: warn user when dma test times out

commit a9df21e34b422f79d9a9fa5c3eff8c2a53491be6 upstream.

Commit adfa543e7314 ("dmatest: don't use set_freezable_with_signal()")
introduced a bug (that is in fact documented by the patch commit text)
that leaves behind a dangling pointer. Since the done_wait structure is
allocated on the stack, future invocations to the DMATEST can produce
undesirable results (e.g., corrupted spinlocks). Ideally, this would be
cleaned up in the thread handler, but at the very least, the kernel
is left in a very precarious scenario that can lead to some long debug
sessions when the crash comes later.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=197605
Signed-off-by: Adam Wallis <awallis@codeaurora.org>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/dma/dmatest.c