]> git.hungrycats.org Git - linux/commit
samples/ftrace: Fix kthread_stop() on ERR_PTR in ftrace-direct-modify
authorHaotian Zhang <vulab@iscas.ac.cn>
Wed, 26 Aug 2026 01:50:34 +0000 (09:50 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 14 Sep 2026 11:36:13 +0000 (13:36 +0200)
commit8de8e5476be39406720216b50238db80bcce9f33
tree618923f653a2d1de28d6623e50221f8a0f6e2ecf
parent6d1c6f228854aa89844fd0152d7ed7ac72a55e89
samples/ftrace: Fix kthread_stop() on ERR_PTR in ftrace-direct-modify

[ Upstream commit d79fb758e7e2e7a181eab630c0545a56041c473d ]

ftrace_direct_init() assigns kthread_run()'s return value to simple_tsk
without an IS_ERR() check. When kthread_run() fails it returns
ERR_PTR(-ENOMEM), but init still returns 0, so the module loads with
simple_tsk holding an error pointer. On unload, ftrace_direct_exit()
then passes that ERR_PTR to kthread_stop(), leading to a
null-pointer-dereference.

Check the return value of kthread_run() with IS_ERR(); on failure,
unregister the ftrace direct call and propagate the error code.

Link: https://patch.msgid.link/20260826015034.10755-1-vulab@iscas.ac.cn
Fixes: ae0cc3b7e7f5 ("ftrace/samples: Add a sample module that implements modify_ftrace_direct()")
Suggested-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
samples/ftrace/ftrace-direct-modify.c