]> git.hungrycats.org Git - linux/commit
regcache: Do not overwrite error code when finalizing cache after error
authorFrancesco Lavra <flavra@baylibre.com>
Tue, 16 Jun 2026 11:44:29 +0000 (13:44 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 16 Jun 2026 13:13:48 +0000 (14:13 +0100)
commit9108f7fa493b4c88cbc09503e0c164244456bad5
tree3b4623b5f661c0c3cdb544c33e05890aa9debb2f
parent34808ac8ddafc3e2c2a59e84eaab0a410e7a0fdc
regcache: Do not overwrite error code when finalizing cache after error

During regcache initialization, if an error occurs in the
cache_ops->populate callback, and if cache operations include an exit
callback, the error code from populate() is overwritten with the return
value from exit(). This hides the error condition from the caller of
regcache_init(), and can cause NULL pointer dereferences when the regcache
is later accessed.

Fixes: 94a3a95f0315 ("regcache: Add ->populate() callback to separate from ->init()")
Signed-off-by: Francesco Lavra <flavra@baylibre.com>
Link: https://patch.msgid.link/20260616114429.1852456-1-flavra@baylibre.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/base/regmap/regcache.c