]> git.hungrycats.org Git - linux/commit
btrfs: don't loop for nowait writes when checking for cross references
authorFilipe Manana <fdmanana@suse.com>
Fri, 15 Nov 2024 15:46:13 +0000 (15:46 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 9 Dec 2024 09:33:01 +0000 (10:33 +0100)
commit99f3cd5a866df54ee4f325af4ec44e72edfa3f98
tree4fa99bf63703db83b3e7cbb1014d11564dccf90d
parentbcacb52a985f1b6d280f698a470b873dfe52728a
btrfs: don't loop for nowait writes when checking for cross references

[ Upstream commit ed67f2a913a4f0fc505db29805c41dd07d3cb356 ]

When checking for delayed refs when verifying if there are cross
references for a data extent, we stop if the path has nowait set and we
can't try lock the delayed ref head's mutex, returning -EAGAIN with the
goal of making a write fallback to a blocking context. However we ignore
the -EAGAIN at btrfs_cross_ref_exist() when check_delayed_ref() returns
it, and keep looping instead of immediately returning the -EAGAIN to the
caller.

Fix this by not looping if we get -EAGAIN and we have a nowait path.

Fixes: 26ce91144631 ("btrfs: make can_nocow_extent nowait compatible")
CC: stable@vger.kernel.org # 6.1+
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/btrfs/extent-tree.c